Skip to content

Add support for shakapacker in server rendering #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2022
Merged

Add support for shakapacker in server rendering #1165

merged 1 commit into from
Feb 25, 2022

Conversation

scraton
Copy link
Contributor

@scraton scraton commented Feb 22, 2022 •
edited
Loading

@scraton scraton changed the title Add support for shakapacker in server rendering (#1157) Add support for shakapacker in server rendering Feb 22, 2022
justin808
justin808 approved these changes Feb 23, 2022
View reviewed changes
Copy link
Collaborator

@justin808 justin808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justin808
Copy link
Collaborator

@BookOfGreg can we get this merged and a release ASAP?

@BookOfGreg BookOfGreg merged commit 58b1a20 into reactjs:master Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justin808 justin808 justin808 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scraton @justin808 @BookOfGreg